Catch reasoning_content from litellm response #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waiting for their release to validate this commit
jamesbraza
reviewed
Jan 23, 2025
| @@ -44,7 +44,7 @@ dev = [ | |||
| "fh-llm-client[local]", | |||
| "fhaviary[xml]", | |||
| "ipython>=8", # Pin to keep recent | |||
| "litellm<1.57.2", # Pin for Router.acompletion typing break from https://github.com/BerriAI/litellm/pull/7594 | |||
| "litellm>1.59.3", # Pin for deepseek support | |||
There was a problem hiding this comment.
Let's just remove this litellm entry from dev, #32 added it
jamesbraza
reviewed
Jan 23, 2025
| @@ -29,7 +29,7 @@ dependencies = [ | |||
| "pydantic~=2.0,>=2.10.1,<2.10.2", | |||
| "tiktoken>=0.4.0", | |||
| "typing-extensions; python_version <= '3.11'", # for typing.override | |||
| 'litellm; python_version < "3.13"', # NOTE: paper-qa==5.3 doesn't support 3.13 yet | |||
| 'litellm>1.59.3; python_version < "3.13"', # NOTE: paper-qa==5.3 doesn't support 3.13 yet | |||
There was a problem hiding this comment.
I think we just get rid of this python_version thing and have one litellm>1.59.3
| @@ -79,6 +79,9 @@ class LLMResult(BaseModel): | |||
| logprob: float | None = Field( | |||
| default=None, description="Sum of logprobs in the completion." | |||
| ) | |||
| reasoning_content: str | None = Field( | |||
| default=None, description="DeepSeek-R1 reasoning content from the LLM." | |||
There was a problem hiding this comment.
Reasoning content may come from other models besides DeepSeek-R1. Maybe adjust to say "Reasoning content from LLMs such as DeepSeek-R1"
maykcaldas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.